Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SmallRye Config to 2.11.0 #26781

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Jul 18, 2022
@radcortez
Copy link
Member Author

@gsmet I'll leave this to your consideration if you want to backport it to 2.11. There are a lot of code changes on SR Config, but they should not impact Quarkus.

@gsmet
Copy link
Member

gsmet commented Jul 18, 2022

OK, I will be a bit conservative here as SR Config is really a critical component.

@radcortez
Copy link
Member Author

Sure.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 18, 2022

Failing Jobs - Building 280b478

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/grpc/deployment 
! Skipped: extensions/opentelemetry/opentelemetry-exporter-jaeger/deployment extensions/opentelemetry/opentelemetry-exporter-otlp/deployment extensions/opentelemetry/opentelemetry/deployment and 19 more

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testEchoStreamReload - More details - Source on GitHub

java.util.concurrent.RejectedExecutionException
	at org.jboss.threads.RejectingExecutor.execute(RejectingExecutor.java:38)
	at org.jboss.threads.EnhancedQueueExecutor.rejectShutdown(EnhancedQueueExecutor.java:2076)

@radcortez
Copy link
Member Author

/cc @edeandrea

@edeandrea
Copy link
Contributor

Thanks @radcortez ! Does this also pull in smallrye/smallrye-config#767?

@radcortez
Copy link
Member Author

Thanks @radcortez ! Does this also pull in smallrye/smallrye-config#767?

Yes.

@edeandrea
Copy link
Contributor

Thank you for keeping me in the loop!

@gsmet gsmet merged commit 8db6af3 into quarkusio:main Jul 19, 2022
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jul 19, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Jul 19, 2022
@edeandrea
Copy link
Contributor

edeandrea commented Oct 31, 2022

Hey @radcortez this doesn't seem to work?

When I try this out using

%knative.quarkus.config.profile.parent=prod
%knative.quarkus.kubernetes.deployment-target=knative
%knative-openshift.quarkus.config.profile.parent=knative
%knative-openshift.quarkus.container-image.builder=openshift
%knative-openshift-17.quarkus.config.profile.parent=knative-openshift
# Some other %knative-openshift-17 properties below

and then I run

 ./mvnw clean package -Dquarkus.kubernetes.deploy=true -Dquarkus.profile=knative-openshift-17 -Dquarkus.kubernetes-client.trust-certs=true -DskipTests -Dquarkus.container-image.group=eric-deandrea-dev -Dquarkus.container-image.registry=

I would expect it to pick up quarkus.kubernetes.deployment-target=knative, but it doesn't. It does, however, pick up quarkus.container-image.builder=openshift.

Does the parent/child hierarchy only traverse 1 level?

If you'd like me to open up a separate issue let me know.

@radcortez
Copy link
Member Author

No, it is probably related to the relocations of the smallrye to the quarkus namespace. If you use smallrye.config instead it works as expected.

I'll have a look.

@radcortez radcortez deleted the srconfig-2110 branch December 16, 2022 11:32
@edeandrea
Copy link
Contributor

Hi @radcortez I just wanted to circle back and see if you've had a chance to take a look at this?

@radcortez
Copy link
Member Author

I believe this should have taken care of it: #28960

@edeandrea
Copy link
Contributor

Thanks @radcortez I'll give it a go!

@edeandrea
Copy link
Contributor

Thanks @radcortez - I've verified all is good! See quarkusio/quarkus-super-heroes#232

@radcortez
Copy link
Member Author

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config mapping to a Map with a List value type fails
3 participants