-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SmallRye Config to 2.11.0 #26781
Conversation
@gsmet I'll leave this to your consideration if you want to backport it to 2.11. There are a lot of code changes on SR Config, but they should not impact Quarkus. |
OK, I will be a bit conservative here as SR Config is really a critical component. |
Sure. |
Failing Jobs - Building 280b478
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/grpc/deployment
! Skipped: extensions/opentelemetry/opentelemetry-exporter-jaeger/deployment extensions/opentelemetry/opentelemetry-exporter-otlp/deployment extensions/opentelemetry/opentelemetry/deployment and 19 more 📦 extensions/grpc/deployment✖
|
/cc @edeandrea |
Thanks @radcortez ! Does this also pull in smallrye/smallrye-config#767? |
Yes. |
Thank you for keeping me in the loop! |
Hey @radcortez this doesn't seem to work? When I try this out using %knative.quarkus.config.profile.parent=prod
%knative.quarkus.kubernetes.deployment-target=knative
%knative-openshift.quarkus.config.profile.parent=knative
%knative-openshift.quarkus.container-image.builder=openshift
%knative-openshift-17.quarkus.config.profile.parent=knative-openshift
# Some other %knative-openshift-17 properties below and then I run ./mvnw clean package -Dquarkus.kubernetes.deploy=true -Dquarkus.profile=knative-openshift-17 -Dquarkus.kubernetes-client.trust-certs=true -DskipTests -Dquarkus.container-image.group=eric-deandrea-dev -Dquarkus.container-image.registry= I would expect it to pick up Does the parent/child hierarchy only traverse 1 level? If you'd like me to open up a separate issue let me know. |
No, it is probably related to the relocations of the I'll have a look. |
Hi @radcortez I just wanted to circle back and see if you've had a chance to take a look at this? |
I believe this should have taken care of it: #28960 |
Thanks @radcortez I'll give it a go! |
Thanks @radcortez - I've verified all is good! See quarkusio/quarkus-super-heroes#232 |
Great! |
https://github.com/smallrye/smallrye-config/releases/tag/2.11.0